Dec 8, 2023·edited Dec 8, 2023Liked by Leonardo Creed
I lead the organization that includes Critique. It was so heartwarming to read this post; thank you for this synthesis! Truly proud of all the hard work put in by all the teams mentioned here!
Interesting (and well researched analysis). I loved the statistics at the end, gives a nice point of reference.
I’m curious to see when the process will be completely taken over by AI, not just suggesting fixes. Maybe one AI suggests and another one rates the suggestions 🙃
One thing that left me curious was what sort of "Static Analysis" is seen as desirable by Critique? I observe "Static Analysis" being mentioned as desirable both by the Reddit person and the Mozilla developers.
To some extent it seems like the interest in static analysis is to help keep devs in line with the style guides & best practices, but I would imagine that a linter / IDE would be the better way to enforce code conventions (while the code is being written, instead of waiting for review). Does anyone have examples of the valuable Static Analysis that Critique performs? If this analysis could be handled by a linter, why wouldn't that be preferred by Google? Too heterogeneous a dev IDE ecosystem?
I lead the organization that includes Critique. It was so heartwarming to read this post; thank you for this synthesis! Truly proud of all the hard work put in by all the teams mentioned here!
LOVE love critique. Great intro on why it rocks
Isn't Critique actually Gerrit, just themed as Critique internally? I recall Gerrit was used for android and it really does look exactly like it.
Interesting (and well researched analysis). I loved the statistics at the end, gives a nice point of reference.
I’m curious to see when the process will be completely taken over by AI, not just suggesting fixes. Maybe one AI suggests and another one rates the suggestions 🙃
Check out CodeApprove (https://codeapprove.com) which brings a lot of what Xooglers love about Critique to GitHub PRs.
Nice detailed analysis on Critique! I saw Nikhil's post on X the other day, but didn't know Critique was this good.
nice to see Gerrit mentioned, I used to work with it.
great post, Leo.
Great inspo for the PR review tool we recently debuted at GitClear (https://www.gitclear.com/help/pull_request_code_review_quality_overview), thanks for posting this!
One thing that left me curious was what sort of "Static Analysis" is seen as desirable by Critique? I observe "Static Analysis" being mentioned as desirable both by the Reddit person and the Mozilla developers.
To some extent it seems like the interest in static analysis is to help keep devs in line with the style guides & best practices, but I would imagine that a linter / IDE would be the better way to enforce code conventions (while the code is being written, instead of waiting for review). Does anyone have examples of the valuable Static Analysis that Critique performs? If this analysis could be handled by a linter, why wouldn't that be preferred by Google? Too heterogeneous a dev IDE ecosystem?